-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test asset compilation on travis #748
Conversation
Code Climate has analyzed commit da8a0ec and detected 0 issues on this pull request. View more on Code Climate. |
Hey @alaxalves, there's a problem with the production environment here. Can you have a look? |
…mapknitter into kaustubh-nair-patch-3
#725 Solves it. |
Okay let me try push those commits here |
The build is still failing @alaxalves |
The issue now is related to the assets, not the builds, BTW this is going well on #685. I think is related to the newer Yarn setup and asset related gems upgrade. |
BTW the build is failing now because of the single asset job. It wasn't running any test previously. |
I don't this MR is needed since it's already fixed here -> #685 |
There might be an issue with database.yml on jenkins with that pull. That I why I opened a sperate pull request
On Jun 28, 2019 3:04 AM, Álax de Carvalho Alves <[email protected]> wrote:
I don't this MR is needed since it's already fixed here -> #685<#685>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#748?email_source=notifications&email_token=AHGMLDEHC3BRKYPL3M7KSXLP4UW7JA5CNFSM4H3PL732YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYYOGMQ#issuecomment-506520370>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AHGMLDEM6H5XR6HE7S6ODGDP4UW7JANCNFSM4H3PL73Q>.
|
Fixed in rails 5 |
Checking if
rake assets:precompile
works correctly on travis since we've switched to Rails 4